On 6/27/24 03:00, Niklas Cassel wrote: > Now when the ap->print_id assignment has moved to ata_port_alloc(), > we can remove the useless ata_sas_port_alloc() wrapper. Same comment as for patch 4: not a fan. But I do like the fact that the port additional initialization is moved to libsas, as that code is completely dependent on libsas. What about this cleanup, which would make more sense: 1) Keep the ata_sas_xxx() exported symbols, even if they are trivial. 2) Move all these wrappers to a new file (libata-sas.c) and make this file compilation dependend on CONFIG_SATA_HOST and CONFIG_SCSI_SAS_LIBSAS. That has the benefit of keeping all the libsas wrappers together and to reduce the binary size for configs that do not enable libsas. Thoughts ? -- Damien Le Moal Western Digital Research
