On Mon, Oct 01, 2007 at 07:39:02PM -0600, Matthew Wilcox wrote: > On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomley wrote: > > One possibility we could do is to add a > > > > struct dma_device { > > struct device dev; > > u64 dma_mask; > > u64 coherent_dma_mask; > > unsigned int max_segment_size; > > /* plus any other DMA parameters */ > > }; > > > > but then every bus that can do DMA would need to include a struct > > dma_device instead of the struct device they do now. Then the IOMMU > > would know it could cast out from struct device to struct dma_device, > > but this would be a lot of work to thread through the current > > infrastructure. Why not just hang these fields off of a struct device, that way if the device doesn't/can't do dma, it only has the "loss" of a single pointer, not all of these fields? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html