On Fri, 7 Jun 2024, Mike Snitzer wrote: > On Fri, Jun 07, 2024 at 07:58:54AM +0200, Christoph Hellwig wrote: > > Hi Jens, hi Martin, > > > > this series converts the blk-integrity settings to sit in the queue > > limits and be updated through the atomic queue limits API. > > > > I've mostly tested this with nvme, scsi is only covered by simple > > scsi_debug based tests. > > > > For MD I found an pre-existing error handling bug when combining PI > > capable devices with not PI capable devices. The fix was posted here > > (and is included in the git branch below): > > > > https://lore.kernel.org/linux-raid/20240604172607.3185916-1-hch@xxxxxx/ > > > > For dm-integrity my testing showed that even the baseline fails to create > > the luks-based dm-crypto with dm-integrity backing for the authentication > > data. As the failure is non-fatal I've not addressed it here. > > Setup is complicated. Did you test in terms of cryptsetup's testsuite? > Or something else? > > Would really like to see these changes verified to work, with no > cryptsetup regressions, before they go in. > > > Note that the support for native metadata in dm-crypt by Mikulas will > > need a rebase on top of this, but as it already requires another > > block layer patch and the changes in this series will simplify it a bit > > I hope that is ok. > > Should be fine, Mikulas can you verify this series to pass > cryptsetup's testsuite before you rebase? Yes - it passes the cryptsetup testsuite. Mikulas > Thanks, > Mike >
