Re: [PATCH 11/11] block: move integrity information into queue_limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 07, 2024 at 09:35:02AM +0200, Hannes Reinecke wrote:
>>> +?????? if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) {
>>> +?????????????? pr_warn("integrity support disabled.\n");
>>> +?????????????? return -EINVAL;
>>> +?????? }
>>> +
>> Why is that an error?
>> Surely 'validate' should not return an error if BLK_DEV_INTEGRITY is 
>> disabled and no limits are set?

Look a few lines above, we'll never get here if no tuple_size is set,
which is now the indicator for metadata support.





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux