On 6/6/24 18:32, Christoph Hellwig wrote: > On Thu, Jun 06, 2024 at 02:46:06PM +0900, Damien Le Moal wrote: >> However, for ATA devices, a drive may spin-up with the CDL feature >> either enabled or disabled by default, depending on the drive. But the >> scsi device cdl_enable field is always initialized to false (CDL >> disabled), regardless of the actual device CDL feature state. > > The same should be true for native SCSI as well, right? Nope, because SPC does not define a knob to turn CDL on/off on the device. For SAS drives, if CDL is supported, it is always enabled/usable. This is why scsi_enable_cdl() is reduced to setting sdev->cdl_enable only (and also why there that ugly "if (is_ata)". > > The patch itself looks good, though: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks. -- Damien Le Moal Western Digital Research
