On Tue, Jun 04, 2024 at 10:45:01AM -0400, Martin K. Petersen wrote:
> Commit 321da3dc1f3c ("scsi: sd: usb_storage: uas: Access media prior
> to querying device properties") triggered a read to LBA 0 before
> attempting to inquire about device characteristics. This was done
> because some protocol bridge devices will return generic values until
> an attached storage device's media has been accessed.
>
> Pierre Tomon reported that this change caused problems on a large
> capacity external drive connected via a bridge device. The bridge in
> question does not appear to implement the READ(10) command.
>
> Issue a READ(16) instead of READ(10) when a device has been identified
> as preferring 16-byte commands (use_16_for_rw heuristic).
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 321da3dc1f3c ("scsi: sd: usb_storage: uas: Access media prior to querying device properties")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=218890
> Reported-by: Pierre Tomon <pierretom+12@xxxxx>
> Suggested-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Tested-by: Pierre Tomon <pierretom+12@xxxxx>
> Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> ---
Thanks a lot, Martin!
Alan Stern
