Am Donnerstag 27 September 2007 schrieb Alan Stern: > On Thu, 27 Sep 2007, Oliver Neukum wrote: > > > > > 1. autosuspend should not be specific to USB > > > > > > Correct. Which means support for it should be added to the SCSI > > > drivers. SCSI autosuspend shouldn't be kluged into usb-storage in a > > > way that basically ignores what the SCSI layer is doing. > > > > It isn't. The decision to autosuspend is based on activity on the bus. > > Now you might argue that the decision to do an autosuspend should > > always propagate upwards from the lowest level of the device tree. > > Then I ask why? > > Because that's how I have always thought of it... :-) > > You're right; there's no showstopping reason particular subsystems like > SCSI can't use a different approach. However bus activity alone isn't > a sufficient criterion. For example, suppose somebody sends a PLAY > AUDIO command to a SCSI cdrom drive. There won't be any bus activity > while the music is playing, but the device will be active and so it > shouldn't be suspended. Thus the sr driver would want to fail an > autosuspend call. sr isn't a device driver. Furthermore it is generic. It can't know whether any power saving measure would prevent some activity from being carried out. It seems to me that we need to be conservative. Any device that is opened by user space must not be autosuspended. But how to fit this into SCSI? > Anyway, if we do end up going this route then there should be a routine > added to the SCSI core which would call the suspend methods for all the > attached devices. This doesn't belong in usb-storage (and even worse, > it shouldn't be duplicated in all the other low-level drivers); rather, > usb-storage should simply be able to call the new routine. We are moving in circles. In an earlier thread you argued that a suspend call should not walk the device tree in case of runtime power management. > Have you thought about how autoresume would fit into this picture? I > don't think you can rely on usb-storage telling the SCSI core to resume > devices when it gets handed a command, because the commands to spin-up > the drives would have to be transmitted first. (The sample patch you > posted will deadlock: The other command can't begin until the spin-up > command completes, and the spin-up command won't get sent to > usb-storage until the original command completes.) In other words, > autoresume must be handled at the level of the SCSI core. That's a difficult one. I need to ponder this a bit. [..] > There's also a philosophical objection. Who is in a better position to > judge when a device like a SCSI drive should be autosuspended: its own > driver (sd) or someone else (usb-storage)? SCSI doesn't know about power management. It cannot, it is not a notion native to SCSI. It just knows how to safely put drives into a state other than fully active (flushing buffers/spin down) You are expecting too much of SCSI core. Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
