On 5/24/24 12:08, Bart Van Assche wrote: >On 5/23/24 16:56, Chanwoo Lee wrote: >> I thought this patch would be appropriate to "fix" the following log. >> * dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err); >> If "Fixing" is not appropriate, could you suggest another word? > >That's something I had not noticed. This is indeed a bug fix. Please add >a "Fixes:" tag as is expected for bug fixes. > >BTW, I think that ufshcd_mcq_abort() can be improved significantly. How >about reworking that function as follows before the bug reported in this >patch is fixed? >- Remove the local variable 'err' (and reintroduce that variable in your >patch). >- Change all 'goto out' statements into 'return FAILED'. >- Add 'return SUCCESS' at the end. > >I expect that this change will make that function easier to read and to >maintain. > >Thanks, > >Bart. Thank you for the good suggestion. I will create a new patch and reply with v2. Thanks, Chanwoo Lee.
