On 24-05-16 08:03:17, Bart Van Assche wrote: > On 5/15/24 21:14, Minwoo Im wrote: > > /* Operation and runtime registers configuration */ > > #define MCQ_CFG_n(r, i) ((r) + MCQ_QCFG_SIZE * (i)) > > -#define MCQ_OPR_OFFSET_n(p, i) \ > > +#define MCQ_OPR_OFFSET_n(hba, p, i) \ > > (hba->mcq_opr[(p)].offset + hba->mcq_opr[(p)].stride * (i)) > Since inline functions are preferred over macros, please convert the > MCQ_OPR_OFFSET_n() macro into an inline function. Okay. I will prepare v2. > > Thanks, > > Bart. >