On 5/14/24 15:07, Avri Altman wrote:
Bart Van Assche wrote:
My understanding is that the above check won't work as intended if
ufshcd_rtt_set() does not modify the RTT value. Wouldn't it be better
to add a boolean in struct ufs_hba that indicates whether or not
ufshcd_rtt_set() has been called before?
>
My intension was to not override RTT should it was written, e.g. from user space.
As this attribute is persistent.
How can RTT be written from user space? There is no sysfs attribute for
configuring the RTT value. If the above refers to a mechanism that
bypasses the UFSHCI kernel driver: I don't think that we should preserve
any configuration changes applied this way. As an example, the SCSI core
does not care about configuration changes applied via the SG interface.
Additionally, what does "persistent" mean in this context?
Thanks,
Bart.
