On Mon, 2024-05-06 at 16:48 -0500, Mike Christie wrote: > On 5/3/24 2:56 PM, Martin Wilck wrote: > > case UNIT_ATTENTION: > > + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == > > 0x0a) > > Do you need to add this check in alua_tur as well? We are checking > for > the NOT_READY case. Good point. I'll add the check, I suppose it can't hurt. But I notice that scsi_test_unit_ready() tries to "eat" UA conditions and alua_tur() calls it with ALUA_FAILOVER_RETRIES (5) retries, so checking the sense key in alua_tur() probably won't make much of a difference, either. [Side note: I am wondering if it makes sense to have scsi_test_unit_ready() retry on UA when called from alua_tur(). After all, alua_tur() is only called to check whether another RTPG must be scheduled. @Hannes?] Regards, Martin
