On Fri, 2024-05-03 at 13:15 +1000, Andrew Donnellan wrote: > This doesn't seem quite right to me, I don't think we can just > redefine > CONFIG_CXL as a bool, but I'll do something like this. Probably won't > bother for CXLFLASH since they'll see it for CXL anyway, but I might > add a warning message on probe to both drivers. The more I look at how to do this, the more issues I see, though perhaps because I personally use olddefconfig more than I use oldconfig. Without changing the default to n, running olddefconfig is liable to switch CXL back on in configs where the user has disabled it. Conversely, if the user has set CXL=y rather than CXL=m, I'm not sure if there's any way to make it such that olddefconfig doesn't reset one symbol or the other to the default m. Honestly, I'm very tempted to be a little more aggressive and a) not bother with trying to play games with symbols, b) change the default to n in this release, c) add a warning printed on probe, and see whether anyone complains. We could also print a message during the build itself, though that kind of noise is liable to break things in other ways? It would be kind of nice if kbuild had some way to mark a symbol for deprecation which could print a warning during configuration. -- Andrew Donnellan OzLabs, ADL Canberra ajd@xxxxxxxxxxxxx IBM Australia Limited
