* I would usually expect a corresponding cover letter for patch series. * Would you like to add parentheses to the function name in the summary phrase? > When dma_alloc_coherent() or qla2x00_start_sp() return an error, call returned? > the callback function qla2x00_els_dcmd_sp_free in qla2x00_sp_release > will call qla2x00_free_fcport() to kfree fcport. We shouldn't call free “fcport”? > qla2x00_free_fcport() again in the error handling path. paths? > Fix this by cleaning the duplicate qla2x00_free_fcport() calls up. Would the wording “Thus delete duplicate qla2x00_free_fcport() calls.” be a bit nicer? … > --- > V2 -> V3: Improve patch summary and provide a patch serises with two separate update steps … * How do you think about to avoid the repetition of version identifiers (according to the selected enumeration style)? * You would probably like to avoid another typo here. Regards, Markus