Hi André, Thanks for the review feedback. On Fri, 5 Apr 2024 at 08:15, André Draszik <andre.draszik@xxxxxxxxxx> wrote: > > Hi Pete, > > On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote: > > Add dt schema documentation and clock IDs for the High Speed Interface > > 2 (HSI2) clock management unit. This CMU feeds high speed interfaces > > such as PCIe and UFS. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > --- > > .../bindings/clock/google,gs101-clock.yaml | 30 +++++++++++++++++-- > > 1 file changed, 28 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101- > > clock.yaml > > index 1d2bcea41c85..a202fd5d1ead 100644 > > --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > > +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > > @@ -32,14 +32,15 @@ properties: > > - google,gs101-cmu-misc > > - google,gs101-cmu-peric0 > > - google,gs101-cmu-peric1 > > + - google,gs101-cmu-hsi2 > > Can you keep this alphabetical and add hsi before misc please. Will fix > > > > clocks: > > minItems: 1 > > - maxItems: 3 > > + maxItems: 5 > > > > clock-names: > > minItems: 1 > > - maxItems: 3 > > + maxItems: 5 > > > > "#clock-cells": > > const: 1 > > @@ -112,6 +113,31 @@ allOf: > > - const: bus > > - const: ip > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - google,gs101-cmu-hsi2 > > this block should also come before misc please. Will fix > > Once done, feel free to add > > Reviewed-by: André Draszik <andre.draszik@xxxxxxxxxx> Thanks! regards, Pete
