On Tue, Apr 09, 2024 at 03:34:13PM +0000, Johannes Thumshirn wrote: > Why did you split this into two functions, with the innermost function > being only called once? > > While it's slightly less of a mess to read this would be fully > sufficient and IMHO more readable (please excuse the whitespace damage): Because having a helper for a specific type of device just simply is good code struture. It might not matter too much now, but as soon as something else gets added your version turns into a mess quickly. But it turns out the rebase caused a real mess in this patch as it marks a function static that now gets used outside the fіle in the scsi tree, and has a weird rename in not actually visible characters, so I'm resending it.
