On Tue, Sep 25, 2007 at 07:05:09PM +0200, Boaz Harrosh wrote: > > @@ -694,7 +702,13 @@ void scsi_finish_command(struct scsi_cmnd *cmd) > > "Notifying upper driver of completion " > > "(result %x)\n", cmd->result)); > > > > - cmd->done(cmd); > > + good_bytes = cmd->request_bufflen; > Please use scsi_bufflen(cmd) this file was already converted to > accessors. Ah; I was basing this on linus + scsi-misc. I guess scsi_lib hadn't been converted because I just took the code from there. > Thanks otherwise looks very good Thank you for the review! -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
