On 3/28/24 15:52, Christoph Hellwig wrote: > On Thu, Mar 28, 2024 at 03:51:09PM +0900, Damien Le Moal wrote: >> I am all for not micro-optimizing the free path right now. >> I am not so sure about the mempool being simpler... And I do see some >> improvements in perf for SMR HDDs with the free list. Could be noise though but >> it feels a little more solid perf-wise. I have not seen any benefit for faster >> devices with the free list though... >> >> If you prefer the mempool, I can go back to using it though, not a big deal. > > A capped free list + dynamic allocation beyond it is exactly what the > mempool is, so reimplementing seems a bit silly. OK. Putting it back then. -- Damien Le Moal Western Digital Research