Re: [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yihang Li <liyihang9@xxxxxxxxxx>
Subject: Re: [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 27 Mar 2024 23:36:45 -0700
Cc: john.g.garry@xxxxxxxxxx, yanaijie@xxxxxxxxxx, jejb@xxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, dlemoal@xxxxxxxxxx, chenxiang66@xxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linuxarm@xxxxxxxxxx, prime.zeng@xxxxxxxxxx, yangxingui@xxxxxxxxxx
In-reply-to: <20240328062657.581460-1-liyihang9@huawei.com>

> +	u8 *p = kzalloc(ALIGN(size, 16), GFP_KERNEL);

No, a magic undocumented 16 here max no sense at all.  See the
discussion on the previous iteration.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B
  - From: Yihang Li

Prev by Date: Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to ARCH_DMA_MINALIGN
Next by Date: Re: [PATCH v3 09/30] block: Pre-allocate zone write plugs
Previous by thread: Re: [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux