Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Wed, 27 Mar 2024 15:15:28 +0000
Cc: Damien Le Moal <dlemoal@xxxxxxxxxx>, Niklas Cassel <cassel@xxxxxxxxxx>, Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>, Sathya Prakash <sathya.prakash@xxxxxxxxxxxx>, Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>, Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx>, "Juergen E. Fischer" <fischer@xxxxxxxxx>, Xiang Chen <chenxiang66@xxxxxxxxxxxxx>, HighPoint Linux Team <linux@xxxxxxxxxxxxxxxxxx>, Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>, Brian King <brking@xxxxxxxxxx>, Lee Duncan <lduncan@xxxxxxxx>, Chris Leech <cleech@xxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Jason Yan <yanaijie@xxxxxxxxxx>, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>, Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>, Shivasharan S <shivasharan.srikanteshwara@xxxxxxxxxxxx>, Chandrakanth patil <chandrakanth.patil@xxxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>, Nilesh Javali <njavali@xxxxxxxxxxx>, GR-QLogic-Storage-Upstream@xxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Avri Altman <avri.altman@xxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, MPT-FusionLinux.pdl@xxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, megaraidlinux.pdl@xxxxxxxxxxxx, mpi3mr-linuxdrv.pdl@xxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20240324235448.2039074-8-hch@lst.de>
Organization: Oracle Corporation
User-agent: Mozilla Thunderbird

On 24/03/2024 23:54, Christoph Hellwig wrote:

Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

+++ b/drivers/scsi/iscsi_tcp.c
@@ -943,6 +943,7 @@ iscsi_sw_tcp_session_create(struct iscsi_endpoint *ep, uint16_t cmds_max,
  	shost->max_id = 0;
  	shost->max_channel = 0;
  	shost->max_cmd_len = SCSI_MAX_VARLEN_CDB_SIZE;
+	shost->dma_alignment = 0;

nit: I am not sure that we really need to zero this, but it also seemsneedless for max_channel also ...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template
  - From: Christoph Hellwig

References:
- convert SCSI to atomic queue limits, part 1
  - From: Christoph Hellwig
- [PATCH 07/23] scsi: add a dma_alignment field to the host and host template
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 06/23] scsi: add a no_highmem flag to struct Scsi_Host
Next by Date: Re: [PATCH 09/23] scsi: use the atomic queue limits API in scsi_add_lun
Previous by thread: Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template
Next by thread: Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]