On 3/19/24 18:46, Shinichiro Kawasaki wrote:
On Mar 11, 2024 / 10:22, Bart Van Assche wrote:
Please remove sdebug_heads, sdebug_cylinders_per and sdebug_sectors_per
instead of making this change. While these values are reported in a
MODE SENSE response, I don't think that it is valuable to keep support
for heads, cylinders and sectors in the scsi_debug driver.
I see. I guess we can return just zero as sdebug_sectors_per in the MODE
SENSE response instead.
I noticed that the three variables you suggest to remove are used in
sdebug_build_parts() also. It is not a good idea to remove the function
and drop or modify the partition table generation feature, probably. I
think we can make the three variables non-global, local variables in the
function. What do you think?
I propose to rework sdebug_build_parts() such that it aligns partitions
on logical block boundaries instead of cylinder boundaries. That will
make sdebug_build_parts() independent of sdebug_heads,
sdebug_cylinders_per and sdebug_sectors and hence will allow these three
variables to be removed.
Thanks,
Bart.
