On 3/8/24 01:45, John Garry wrote:
On 07/03/2024 17:59, Bart Van Assche wrote:
The approach to use multiple files in order to avoid #ifdefs in .c files
is strongly preferred in Linux kernel code.
Then what about this change in this patch:
> +#ifdef CONFIG_CRC_T10DIF
> MODULE_PARM_DESC(dif, "data integrity field type: 0-3 (def=0)");
> MODULE_PARM_DESC(dix, "data integrity extensions mask (def=0)");
> +#endif
This ifdef has been removed in v3.
BTW, I don't think that modparams should be compiled out like this.
Better would be to leave as is, and error when the user sets them.
Hmm ... aren't unrecognized kernel module parameters ignored silently?
See also unknown_module_param_cb() in the kernel code.
scsi_debug is complex, to put it gently. I don't see any value in
splitting it into further files, spreading the complexity. More
especially when there seems to be little gain. scsi_debug requires
CRC_T10DIF, so let it have it.
We are using the scsi_debug driver in Android for kernel regression
testing but there are no plans to support T10-PI in Android. Any
proposals for alternative solutions for removing the dependency of the
scsi_debug driver on the CRC_T10DIF code are welcome.
Thanks,
Bart.
