On 3/11/24 03:46, John Garry wrote:
On 22/02/2024 21:44, Bart Van Assche wrote:
+ sdkp->permanent_stream_count = desc - start;
+ if (sdkp->permanent_stream_count < 2) {
+ sd_printk(KERN_INFO, sdkp,
+ "Unexpected: RSCS has been set and the permanent stream
count is %u\n",
+ sdkp->permanent_stream_count);
+ return;
+ }
+
+ sd_printk(KERN_INFO, sdkp, "permanent stream count = %d\n",
+ sdkp->permanent_stream_count);
I have been testing a recent linux-next (which includes this change),
and I now see this following kernel log just for writing to the bdev
file, like:
# mnt/test-pwritev2 -d -l 512 -p 512 /dev/sda
wrote 512 bytes at pos 512 write_size=512
# [ 22.339526] sd 0:0:0:0: [sda] permanent stream count = 5
Is that log really required, especially at info level?
That is a scsi_debug disk - I assume that the relevant io hint feature
is now default enabled there.
Hi John,
How about removing the sd_printk() call mentioned above and adding a
sysfs attribute instead that reports the number of permanent streams?
Thanks,
Bart.
