On 08/03/2024 19:41, Igor Pylypiv wrote:
Even though some drivers don't set proc_name, it won't make much difference to set as DRV_NAME. Also add LIBSAS_SHT_BASE_NO_SLAVE_INIT for the hisi_sas drivers which have custom .slave_alloc and .slave_configure methods.Looks like libata drivers have no problem overriding default values that were set by __ATA_BASE_SHT. For example __ATA_BASE_SHT sets .can_queue .sdev_attrs and then AHCI_SHT overrides those with AHCI specific values: #define AHCI_SHT(drv_name) \ ATA_NCQ_SHT(drv_name), \
which tag are you looking at here? That looks like an old definition of AHCI_SHT(). There was a significant change for this in the following: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/ata/ahci.h?h=v5.14&id=071e86fe2872e7442e42ad26f71cd6bde55344f8 Thanks, John
