RE: [PATCH v1 5/7] ufs: host: mediatek: rename host power control API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Peter Wang <peter.wang@xxxxxxxxxxxx>
> 
> From: Po-Wen Kao <powen.kao@xxxxxxxxxxxx>
> 
> Host power control is control crypto sram power.
> Rename it for easy maintain.
> 
> Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>
> Signed-off-by: Peter Wang <peter.wang@xxxxxxxxxxxx>
> Signed-off-by: Po-Wen Kao <powen.kao@xxxxxxxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>


> ---
>  drivers/ufs/host/ufs-mediatek-sip.h | 13 +++----------
>  drivers/ufs/host/ufs-mediatek.c     |  4 ++--
>  2 files changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/ufs/host/ufs-mediatek-sip.h b/drivers/ufs/host/ufs-mediatek-
> sip.h
> index 30146bb1ccbe..fd640846910a 100755
> --- a/drivers/ufs/host/ufs-mediatek-sip.h
> +++ b/drivers/ufs/host/ufs-mediatek-sip.h
> @@ -16,7 +16,7 @@
>  #define UFS_MTK_SIP_DEVICE_RESET          BIT(1)
>  #define UFS_MTK_SIP_CRYPTO_CTRL           BIT(2)
>  #define UFS_MTK_SIP_REF_CLK_NOTIFICATION  BIT(3)
> -#define UFS_MTK_SIP_HOST_PWR_CTRL         BIT(5)
> +#define UFS_MTK_SIP_SRAM_PWR_CTRL         BIT(5)
>  #define UFS_MTK_SIP_GET_VCC_NUM           BIT(6)
>  #define UFS_MTK_SIP_DEVICE_PWR_CTRL       BIT(7)
> 
> @@ -31,13 +31,6 @@ enum ufs_mtk_vcc_num {
>         UFS_VCC_MAX
>  };
> 
> -/*
> - * Host Power Control options
> - */
> -enum {
> -       HOST_PWR_HCI = 0,
> -       HOST_PWR_MPHY
> -};
> 
>  /*
>   * SMC call wrapper function
> @@ -78,8 +71,8 @@ static inline void _ufs_mtk_smc(struct ufs_mtk_smc_arg
> s)  #define ufs_mtk_device_reset_ctrl(high, res) \
>         ufs_mtk_smc(UFS_MTK_SIP_DEVICE_RESET, &(res), high)
> 
> -#define ufs_mtk_host_pwr_ctrl(opt, on, res) \
> -       ufs_mtk_smc(UFS_MTK_SIP_HOST_PWR_CTRL, &(res), opt, on)
> +#define ufs_mtk_sram_pwr_ctrl(on, res) \
> +       ufs_mtk_smc(UFS_MTK_SIP_SRAM_PWR_CTRL, &(res), on)
> 
>  #define ufs_mtk_get_vcc_num(res) \
>         ufs_mtk_smc(UFS_MTK_SIP_GET_VCC_NUM, &(res)) diff --git
> a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index
> ae184e4f90e6..2caf0c1d4e17 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1376,7 +1376,7 @@ static int ufs_mtk_suspend(struct ufs_hba *hba,
> enum ufs_pm_op pm_op,
>         if (ufshcd_is_link_off(hba))
>                 ufs_mtk_device_reset_ctrl(0, res);
> 
> -       ufs_mtk_host_pwr_ctrl(HOST_PWR_HCI, false, res);
> +       ufs_mtk_sram_pwr_ctrl(false, res);
> 
>         return 0;
>  fail:
> @@ -1397,7 +1397,7 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum
> ufs_pm_op pm_op)
>         if (hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL)
>                 ufs_mtk_dev_vreg_set_lpm(hba, false);
> 
> -       ufs_mtk_host_pwr_ctrl(HOST_PWR_HCI, true, res);
> +       ufs_mtk_sram_pwr_ctrl(true, res);
> 
>         err = ufs_mtk_mphy_power_on(hba, true);
>         if (err)
> --
> 2.18.0






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux