> > On Tue, 2024-03-05 at 23:00 +0200, Avri Altman wrote: > > Move out the actual command issue from exec_dev_cmd so it can be used > > elsewhere. While at it, remove a redundant "lrbp->cmd = NULL" > > assignment. Also, as a free bonus, call the upiu trace if it doesn't. > > > This statement is a bit strange, what it is "if it doesn't"? > > from the change, the patch refactors command issue for broader usage > and enhance UPIU tracing, isolate the command issuance logic from > `ufshcd_exec_dev_cmd` to allow reuse across different contexts. What I meant is, that I see no downside for including the bsg path in the upiu trace event. Do you object to that? Thanks, Avri
