RE: [PATCH 1/4] scsi: ufs: Re-use device management locking code

[Avri Altman <Avri.Altman@xxxxxxx>]

> On 3/4/24 01:23, Avri Altman wrote:
> >   /**
> >    * ufshcd_exec_dev_cmd - API for sending device management requests
> >    * @hba: UFS hba
> > @@ -3291,11 +3305,6 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba
> *hba,
> >       struct ufshcd_lrb *lrbp;
> >       int err;
> >
> > -     /* Protects use of hba->reserved_slot. */
> > -     lockdep_assert_held(&hba->dev_cmd.lock);
> > -
> > -     down_read(&hba->clk_scaling_lock);
> > -
> >       lrbp = &hba->lrb[tag];
> >       lrbp->cmd = NULL;
> >       err = ufshcd_compose_dev_cmd(hba, lrbp, cmd_type, tag);
> 
> Please restore the lockdep_assert_held() call.
Done.

> 
> > -     /* Protects use of hba->reserved_slot. */
> > -     lockdep_assert_held(&hba->dev_cmd.lock);
> > -
> > -     down_read(&hba->clk_scaling_lock);
> > -
> >       lrbp = &hba->lrb[tag];
> >       lrbp->cmd = NULL;
> >       lrbp->task_tag = tag;
> 
> Same comment here - please restore the lockdep_assert_held() call.
Done.

Thanks,
Avri

> 
> Otherwise this patch looks good to me.
> 
> Thanks,
> 
> Bart.