On 2/29/2024 12:22 AM, Bart Van Assche wrote:
On 2/27/24 21:34, Ram Prakash Gupta wrote:
This reverts commit 1d969731b87f122108c50a64acfdbaa63486296e.
Approx 28% random perf IO degradation is observed by suspending clk
scaling only when clks are scaled down. Concern for original fix was
power consumption, which is already taken care by clk gating by putting
the link into hibern8 state.
Signed-off-by: Ram Prakash Gupta <quic_rampraka@xxxxxxxxxxx>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c416826762e9..f6be18db031c 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -1586,7 +1586,7 @@ static int ufshcd_devfreq_target(struct device
*dev,
ktime_to_us(ktime_sub(ktime_get(), start)), ret);
out:
- if (sched_clk_scaling_suspend_work && !scale_up)
+ if (sched_clk_scaling_suspend_work)
queue_work(hba->clk_scaling.workq,
&hba->clk_scaling.suspend_work);
What is the base kernel version for your tests? Was this patch series
included in your kernel tree: "[PATCH V6 0/2] Add CPU latency QoS
support for ufs driver"
(https://lore.kernel.org/all/20231219123706.6463-1-quic_mnaresh@xxxxxxxxxxx/)?
Thanks,
Bart.
Hi Bart,
kernel version used is 6.1 and QoS support for CPU latency is present.
Thanks,
Ram
