Re: [PATCH v3 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2024 20:16, Igor Pylypiv wrote:
The added sysfs attributes group enables the configuration of NCQ Priority
feature for HBAs that rely on libsas to manage SATA devices.

Signed-off-by: Igor Pylypiv<ipylypiv@xxxxxxxxxx>

Apart from comment on v1 HW:
Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

---
  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++++++
  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
  3 files changed, 18 insertions(+)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index 3c555579f9a1..97864b56a71f 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1734,6 +1734,11 @@ static struct attribute *host_v1_hw_attrs[] = {
ATTRIBUTE_GROUPS(host_v1_hw); +static const struct attribute_group *sdev_groups_v1_hw[] = {
+	&sas_ata_sdev_attr_group,

IIRC, this driver never supported SATA

+	NULL
+};
+
  static const struct scsi_host_template sht_v1_hw = {
  	.name			= DRV_NAME,
  	.proc_name		= DRV_NAME,
@@ -1758,6 +1763,7 @@ static const struct scsi_host_template sht_v1_hw = {
  	.compat_ioctl		= sas_ioctl,
  #endif
  	.shost_groups		= host_v1_hw_groups,
+	.sdev_groups		= sdev_groups_v1_hw,
  	.host_reset             = hisi_sas_host_reset,
  };





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux