On 2/29/24 09:29, Damien Le Moal wrote:
On 2024/02/29 9:23, Bart Van Assche wrote:
+ if (sdev->type == TYPE_ZBC) {
+ /* READ16/WRITE16/SYNC16 is mandatory for ZBC devices */
+ sdev->use_16_for_rw = 1;
+ sdev->use_16_for_sync = 1;
scsi_add_lun() sets use_10_for_rw to "1" so can we clear it to "0" here again
like was done in the sd_zbc.c hunk below that you removed ?
Hi Damien,
Although it would be easy to make that change, will it cause any
difference in behavior? sd_setup_read_write_cmnd() checks the value of
.use_16_for_rw before it checks the value of .use_10_for_rw. Hence, the
value of .use_10_for_rw does not matter if .use_16_for_rw is set.
Thanks,
Bart.
