On 2/22/2024 1:55 AM, Bart Van Assche wrote:
On 2/21/24 01:13, Can Guo wrote:
I am going to push some BUG fixes for Qualcomm UFSHCI MCQ engine, one
of which would count on a vops in ufshcd_send_command(). My original
plan was to add a new vops.mcq_setup_xfer_req() to differentiate from
the existing one used in legacy mode. But if Rohit moves the existing
.setup_xfer_req() up, I can use it instead of introducing the new one.
Hi Can,
If an if-statement can be avoided in the hot path by introducing a new
callback pointer for MCQ code then I prefer the approach of introducing
a new callback instead of moving the setup_xfer_req() call.
Hi Bart,
The if-statement you are mentioning here, is it the if (hba->vops &&
hba->vops->setup_xfer_req) or if (is_mcq_enabled(hba))?
Thanks,
Can Guo.
Thanks,
Bart.
