Re: [PATCH 24/24 ver3 ] ide-scsi.c: convert to data accessors and !use_sg cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 18 September 2007, Boaz Harrosh wrote:
> 
>  - Convert ide-scsi to the new data accessors and cleanup
>    the !use_sg code paths.
> 
>   In old code the driver was trying to translate narrow commands,
>   if received, to wide commands. This code  path still assumed
>   scsi_cmnd->request_buffer is a linear char pointer.
>   This means that this driver was broken since 2.6.17.

2.6.17 so it has been broken for the last *six* kernel releases
(and 2.6.17 == 18 Jun 2006 so more than a year in the timescale).

This raises serious questions whether it is really worth to fix it

>   As suggested by Christoph Hellwig I set
>   use_10_for_rw = 1; and use_10_for_ms = 1;
>   for this device and completely killed the translation.
> 
> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>

anyway patch looks good

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux