Bart,
On Thu, Feb 15, 2024 at 10:28:06AM -0800, Bart Van Assche wrote:
> On 2/14/24 14:14, Martin K. Petersen wrote:
> > Commit c92a6b5d6335 ("scsi: core: Query VPD size before getting full
> > page") removed the logic which checks whether a VPD page is present on
> > the supported pages list before asking for the page itself. That was
> > done because SPC helpfully states "The Supported VPD Pages VPD page
> > list may or may not include all the VPD pages that are able to be
> > returned by the device server". Testing had revealed a few devices
> > that supported some of the 0xBn pages but didn't actually list them in
> > page 0.
> >
> > Julian Sikorski bisected a problem with his drive resetting during
> > discovery to the commit above. As it turns out, this particular drive
> > firmware will crash if we attempt to fetch page 0xB9.
> >
> > Various approaches were attempted to work around this. In the end,
> > reinstating the logic that consults VPD page 0 before fetching any
> > other page was the path of least resistance. A firmware update for the
> > devices which originally compelled us to remove the check has since
> > been released.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Cc: Bart Van Assche <bvanassche@xxxxxxx>
> > Fixes: c92a6b5d6335 ("scsi: core: Query VPD size before getting full page")
> > Reported-by: Julian Sikorski <belegdol@xxxxxxxxx>
> > Tested-by: Julian Sikorski <belegdol@xxxxxxxxx>
> > Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
>
> BTW, here is another report related to this patch:
> https://lore.kernel.org/linux-scsi/64phxapjp742qob7gr74o2tnnkaic6wmxgfa3uxn33ukrwumbi@cfd6kmix3bbm/
>
> Vitaly, can you help with testing this patch? See also:
> https://lore.kernel.org/linux-scsi/20240214221411.2888112-1-martin.petersen@xxxxxxxxxx/
With this patch applied over 6.6.16 problem still persists.
Also reading page 0x89 (mentioned in patch description) does not show any signs
of crash (any errors in dmesg with it of with the following reads):
[root@host-226 ~]# sg_vpd -p 0x89 /dev/sdc
ATA information VPD page:
SAT Vendor identification: LSI
SAT Product identification: LSI SATL
SAT Product revision level: 0008
Device signature indicates SATA transport
Command code: 0xec
ATA command IDENTIFY DEVICE response summary:
model: WDC WD2005FBYZ-01YCBB2
serial number: WD-WMC6N0J5VKLH
firmware revision: RR07
Thanks,
