On 2/15/24 11:07 AM, Maurizio Lombardi wrote: > čt 15. 2. 2024 v 17:44 odesílatel <michael.christie@xxxxxxxxxx> napsal: >> Do you need something similar for the pr related dirs/files or how does >> that work but not this? >> > > I think that in that case it won't be necessary because the pr code is executed > by a kernel thread that calls the execute_cmd() callback, not by a > user process in kernel context, > but I will try and eventually I will report back the findings > Ignore my comment. I was thinking of something completely different and figured out I was wrong when I looked into it. The target parts look ok: Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx> I have no idea about the creds part. If the patch: commit 581dd69830341d299b0c097fc366097ab497d679 Author: Thiébaud Weksteen <tweek@xxxxxxxxxx> Date: Mon May 2 10:49:52 2022 +1000 firmware_loader: use kernel credentials when reading firmware you referenced is the correct way to do it, then it looks ok.