On Tue, 2024-02-13 at 21:08 +0300, Dan Carpenter wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > There is one goto where "sched_clk_scaling_suspend_work" is true but > "scale_up" is uninitialized. It leads to a Smatch uninitialized > variable > warning: > > drivers/ufs/core/ufshcd.c:1589 ufshcd_devfreq_target() error: > uninitialized symbol 'scale_up'. > > Fixes: 1d969731b87f ("scsi: ufs: core: Only suspend clock scaling if > scaling down") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>