On Mon, Jan 29, 2024 at 05:02:34PM +0800, Guixin Liu wrote: > The sd_index_ida should be destroy when the sd module exit. > > Signed-off-by: Guixin Liu <kanie@xxxxxxxxxxxxxxxxx> > --- > drivers/scsi/sd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 0833b3e6aa6e..8b88cba88da2 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -4079,6 +4079,8 @@ static void __exit exit_sd(void) > > for (i = 0; i < SD_MAJORS; i++) > unregister_blkdev(sd_major(i), "sd"); > + > + ida_destroy(&sd_index_ida); Looks good to me. Reviewed-by: Benjamin Block <bblock@xxxxxxxxxxxxx> -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vors. Aufs.-R.: Wolfgang Wendt / Geschäftsführung: David Faller Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294