Hi Mike,
On Tue, Feb 06, 2024 at 08:19:19PM -0600, Mike Christie wrote:
> +static int target_try_configure_unmap(struct se_device *dev,
> + const char *config_opt)
> +{
> + if (!dev->transport->configure_unmap)
> + return 0;
> +
> + if (!target_dev_configured(dev)) {
> + pr_err("Generic Block Discard setup for %s requires device to be configured\n",
> + config_opt);
> + return -ENODEV;
> + }
> +
> + if (!dev->transport->configure_unmap(dev)) {
> + pr_err("Generic Block Discard setup for %s failed\n",
> + config_opt);
> + return -ENOSYS;
> + }
> +
> + return 0;
> +}
> +
> static ssize_t emulate_tpu_store(struct config_item *item,
> const char *page, size_t count)
> {
> @@ -776,11 +797,9 @@ static ssize_t emulate_tpu_store(struct config_item *item,
> * Discard supported is detected iblock_create_virtdevice().
> */
> if (flag && !da->max_unmap_block_desc_count) {
> - if (!dev->transport->configure_unmap ||
You removed this check but that callout is not mandatory and exists just in
2 backstore modules.
BR,
Dmitry
