Re: [PATCH v1 1/1] ufs: core: fix shift issue in ufshcd_clear_cmd

To: alice.chao@xxxxxxxxxxxx, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Avri Altman <avri.altman@xxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Subject: Re: [PATCH v1 1/1] ufs: core: fix shift issue in ufshcd_clear_cmd
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Mon, 5 Feb 2024 09:08:08 -0800
Cc: wsd_upstream@xxxxxxxxxxxx, stanley.chu@xxxxxxxxxxxx, peter.wang@xxxxxxxxxxxx, powen.kao@xxxxxxxxxxxx, naomi.chu@xxxxxxxxxxxx, cc.chou@xxxxxxxxxxxx, tun-yu.yu@xxxxxxxxxxxx, chun-hung.wu@xxxxxxxxxxxx, casper.li@xxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20240205104905.24929-1-alice.chao@mediatek.com>
User-agent: Mozilla Thunderbird

On 2/5/24 02:49, alice.chao@xxxxxxxxxxxx wrote:

When task_tag > 32 (in mcq mode), 1U << task_tag will out of bound

       ^^^^^^^^^^^^^
       task_tag >= 32 and sizeof(unsigned int) == 4

for u32 mask. Fix this bug to prevent SHIFT_ISSUE (Bitwise shifts
that are out of bounds for their data type).


Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

References:
- [PATCH v1 1/1] ufs: core: fix shift issue in ufshcd_clear_cmd
  - From: alice.chao