On 12/20/23 06:48, Manivannan Sadhasivam wrote:
On Mon, Dec 18, 2023 at 02:52:15PM -0800, Bart Van Assche wrote:
Calling ufshcd_hba_exit() from a function that is called asynchronously
from ufshcd_init() is wrong because this triggers multiple race
conditions. Instead of calling ufshcd_hba_exit(), log an error message.
This also means that during failure, resources will not be powered OFF. IMO, a
justification is needed why it is OK to left them powered ON.
I have never seen ufshcd_async_scan() fail other than during hardware bringup.
Has anyone else ever observed a ufshcd_async_scan() failure?
Reported-by: Daniel Mentz <danielmentz@xxxxxxxxxx>
Fixes: 1d337ec2f35e ("ufs: improve init sequence")
No need to backport this patch?
Isn't the "Fixes:" tag sufficient? I don't think that it it necessary to add a
"Cc: stable" tag if a "Fixes:" tag is present.
Thanks,
Bart.
