Gilbert Wu wrote:
Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does not work on SATA device. ( The smartctl v5.38 does need "-d ata" option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ bit from status register which is treated as AC_ERR_HSM (host state machine violation) error by top layer if it set to one. The firmware of aic94xx chip handle all ATA handshaking, data transfer and return ATA output register which is sent by the device. So the DRQ bit may not reflect the last state of device when the command finished and it is no meaning for the caller. Signed-off-by: Gilbert Wu <gilbert_wu@xxxxxxxxxxx>
ACK, thanks for your patience
@@ -427,6 +459,9 @@ flags |= STP_AFFIL_POLICY; scb->ata_task.flags = flags; } + if (!is_ata_rw_cmd(scb->ata_task.fis.command)) + scb->ata_task.ata_flags|=CSMI_TASK;
Minor style complaint: add spaces around "|=" Regards, Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
