Re: [PATCH v4 0/2] mpt3sas: Additional retries when reading specific registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Patrick,

On Sun, Dec 10, 2023 at 1:51 AM <patrick.strateman@xxxxxxxxx> wrote:
>
> The loop in _base_readl_ext_retry is wrong, it runs 30 times regardless
> of the result from readl.
>
> This results in the value being incorrect and the device being reset
> nearly continuously.
>
> if (ret_val == 0) continue;
>
> should be
>
> if (ret_val != 0) break;

>The above code change is already submitted and accepted .
Reference : https://patchwork.kernel.org/project/linux-scsi/patch/20231020105849.6350-1-ranjan.kumar@xxxxxxxxxxxx/

> On 8/30/23 18:39, Martin K. Petersen wrote:
> > Ranjan,
> >
> >> Doorbell and Host diagnostic registers could return 0 even
> >> after 3 retries and that leads to occasional resets of the
> >> controllers, hence increased the retry count to thirty.
> > Applied to 6.6/scsi-staging, thanks!
> >

Thanks,
Ranjan

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux