On 11/28/23 16:06, bugzilla-daemon@xxxxxxxxxx wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=218198 > > Bug ID: 218198 > Summary: Suspend/Resume Regression with attached ATA devices > Product: SCSI Drivers > Version: 2.5 > Hardware: Intel > OS: Linux > Status: NEW > Severity: high > Priority: P3 > Component: Other > Assignee: scsi_drivers-other@xxxxxxxxxxxxxxxxxxxx > Reporter: dmummenschanz@xxxxxx > Regression: No > > Hello, > > the following commit from Kernel 6.7-rc1: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/ata/libata-core.c?id=d035e4eb38b3ea5ae9ead342f888fd3c394b0fe0 > > introduced a regression on my system where after successful resuming the CPU > won't enter lower Package Sates below pc2 even after letting it sit for 15+ > minutes. Reverting this commit fixed the issue on my system with two ata > drives. Anyone experiencing the same issue? > > I'm happy to try any troubleshooting steps or provide more details if needed. Could you try adding this: diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 09ed67772fae..8d4871fff099 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -6185,6 +6185,9 @@ void ata_pci_shutdown_one(struct pci_dev *pdev) for (i = 0; i < host->n_ports; i++) { struct ata_port *ap = host->ports[i]; + /* Wait for EH to complete before freezing the port */ + ata_port_wait_eh(ap); + ap->pflags |= ATA_PFLAG_FROZEN; /* Disable port interrupts */ and see if this changes anything ? Beside that, I am at a loss seeing what is going on. The commit you mention essentially reverted an earlier change that is not necessary, bringing back ata_pci_shutdown_one() to the how it was for ages... When you say "successful resuming", what exactly are you talking about ? System resume from suspend-to-ram ? from hibernation (suspend to disk) ? I can always revert this revert, but I would rather understand why that is needed. Do you see any suspicious libata EH activity in dmesg ? Also, are the lower Package Sates transitions automatic or driven by the kernel PM core ? I do not know that. If it is the latter, does the pc2 state also include adapters ? Isn't it limited to the CPU power state ? I ask because if it is and libata EH is in a bad loop constantly running after resume, that would explain why you cannot reach a lower CPU power state. -- Damien Le Moal Western Digital Research
