On Mon, 23 Oct 2023 19:50:57 +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > This pattern of strncpy(dest, src, strlen(src)) is extremely bug-prone. > This pattern basically never results in NUL-terminated destination > strings unless `dest` was zero-initialized. The current implementation > may be accidentally correct as tw_dev is zero-allocated via: > > [...] Applied to 6.8/scsi-queue, thanks! [1/1] scsi: 3w-sas: replace deprecated strncpy with strscpy https://git.kernel.org/mkp/scsi/c/7936a19e944b -- Martin K. Petersen Oracle Linux Engineering