On Tue, Sep 11 2007 at 18:41 +0300, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 11 Sep 2007, Boaz Harrosh wrote: > >> - regrouped variables for easier reviewing of next patch >> - Support of cmnd==NULL in call to scsi_send_eh_cmnd() >> - In the copy_sense case set transfer size to the minimum >> size of sense_buffer and passed @sense_bytes. cmnd[4] is >> set accordingly. >> - REQUEST_SENSE is set into cmnd[0] so if @sense_bytes is >> not Zero passed cmnd can/should be NULL. >> - Also save/restore resid of faild command. > > The "if (sense_bytes)" block doesn't set scmd->cmd_len. Yes, I know > that value gets changed by the usb-storage driver, but nevertheless it > should be set here to 6. > > Apart from that, this looks fine to me. > > Alan Stern > Thanks a million. The 22:45 effect again. Will patch ver4 of this patch as reply to first one. Boaz - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
