On 11/10/2023 12:16 AM, Manivannan Sadhasivam wrote:
On Thu, Nov 09, 2023 at 07:55:14AM -0600, Rob Herring wrote:
On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
On 11/6/23 06:48, Rob Herring wrote:
On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
The Message Signaled Interrupts (MSI) has been introduced
to UFS driver since the MCQ be enabled.
Not really relevant when a driver supported MSI, but the when the h/w
did. Has UFS always supported MSI? It was added in some version of the
spec?
MSI support has been introduced in UFSHCI version 4.0 and I think that
the controller vendor can decide whether or not to implement MSI. Does
this mean that the patch needs to be improved?
Yes, this information is what should be in the commit msg rather than
driver details.
Yes, agreed. Ziqi, please update the commit message to incorporate the hw
details about when MCQ/MSI got introduced. Devicetree binding should describe
the hw, not the driver.
Thank you all, I will update the commit message in next version.
- Ziqi
- Mani
Rob
