On Tue, Nov 07, 2023 at 10:14:40AM -0800, Justin Tee wrote: > Hi Dan, > > > On Tue, Nov 7, 2023 at 7:26 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > This is a couple years old but apparently, but I've never reported it > > before. Smatch wanted a goto try_rdf; here. Not sure if Smatch is > > correct. If not just ignore this it. These are one time emails. > > I think return –EIO on line 4353 is fine. If lpfc_nlp_get(ndlp) from > line 4350 returned NULL, then we want to early return and not issue an > RDF. This behavior is consistent with the !ndlp check on lines > 4307–4308. If we don’t have a valid ndlp login context with the > Fabric, then there’s no point to goto try_rdf to issue an RDF. > > And for line 4353, I confirm that the only unwind needed is > lpfc_els_free_iocb from the previous line. Thanks, Justin! regards, dan carpenter
