Re: [PATCH v2 03/13] scsi: fnic: Add and improve log messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/6/23 20:55, Karan Tilak Kumar (kartilak) wrote:
On Thursday, November 2, 2023 12:28 AM, Hannes Reinecke <hare@xxxxxxx> wrote:

On 10/27/23 20:02, Karan Tilak Kumar wrote:
Add link related log messages in fnic_fcs.c, Improve log message in
fnic_fcs.c, Add log message in vnic_dev.c.

Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx>
Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
---
   drivers/scsi/fnic/fnic_fcs.c | 36 ++++++++++++++++++++++++------------
   drivers/scsi/fnic/vnic_dev.c |  4 ++++
   2 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/fnic/fnic_fcs.c
b/drivers/scsi/fnic/fnic_fcs.c index 55632c67a8f2..203ffec625a4 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -64,8 +64,8 @@ void fnic_handle_link(struct work_struct *work)
                     new_port_speed);
     if (old_port_speed != new_port_speed)
             FNIC_MAIN_DBG(KERN_INFO, fnic->lport->host,
-                           "Current vnic speed set to :  %llu\n",
-                           new_port_speed);
+                           "fnic<%d>: %s: %d: Current vnic speed set to: %llu\n",
+                           fnic->fnic_num, __func__, __LINE__, new_port_speed);

Please update FNIC_MAIN_DBG() to use the 'fnic' structure as an argument, then you don't have to prefix all messages with 'fnic<%d>'.

Cheers,

Hannes

Thanks for the review comments, Hannes. I'll make suitable changes in v3.
Please advise whether I'll need to supersede v2 with a "git send-email --in-reply-to" so that your
"Reviewed-by" tag for other patches gets preserved.
I'm not exactly sure how the process works. The goal is to reduce the number of re-reviews of patches, if possible.
Any pointers with respect to this will help.

Please add the 'Reviewed-by' tags for the next submission; that will indicated to reviewers which of these patches already have been reviewed
and which need further attention.
Hint: there is the 'b4' tool, which will scrape the patches from the mailing list _and_ add the 'Reviewed-by' tags. Maybe give it a go.

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux