Re: [PATCH v3] scsi: ufs: ufs-sysfs: Expose UFS power info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bart,

On 11/2/2023 1:07 AM, Bart Van Assche wrote:
On 10/31/23 21:00, Can Guo wrote:
+    return sysfs_emit(buf, "%s\n", hba->pwr_info.hs_rate ?
+ ufshcd_ufs_hs_gear_to_string(hba->pwr_info.gear_rx) :
+ ufshcd_ufs_pwm_gear_to_string(hba->pwr_info.gear_rx));
+}

A nit: this is not how kernel code should be indented. I think that
"ufshcd_..." should be aligned with "buf,".

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>


Will address it in next version.


Thanks,

Can Guo.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux