On Mon, 10 Sep 2007 17:23:52 +0300 Boaz Harrosh wrote:
Hi Boaz,
Just a small nit: several of the kernel-doc lines need ':' added.
See below.
> Sign-off-by Boaz Harrosh <bharrosh@xxxxxxxxxxx>
> ---
> drivers/scsi/scsi_error.c | 133 +++++++++++++++++++++++++++------------------
> include/scsi/scsi_eh.h | 23 ++++++++-
> 2 files changed, 102 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 0bcfbe5..0327e20 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -590,42 +590,24 @@ static void scsi_abort_eh_cmnd(struct scsi_cmnd *scmd)
> }
>
> /**
> - * scsi_send_eh_cmnd - submit a scsi command as part of error recory
> + * scsi_prep_eh_cmnd - Save a scsi command info as part of error recory
> * @scmd: SCSI command structure to hijack
> - * @cmnd: CDB to send
> + * @sesci structure to save restore information
* @sesci:
> + * @cmnd: CDB to send. Can be NULL if no new cmnd is needed
> * @cmnd_size: size in bytes of @cmnd
> - * @timeout: timeout for this request
> * @copy_sense: request sense data if set to 1
> *
> **/
> -static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
> - int cmnd_size, int timeout, int copy_sense)
> +void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd,
> + struct scsi_eh_save_cmnd_info *sesci, unsigned char *cmnd,
> + int cmnd_size, int copy_sense)
> {
> @@ -676,7 +659,62 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
>
> +/**
> + * scsi_restore_eh_cmnd - Restore a scsi command info as part of error recory
> + * @scmd: SCSI command structure to restore
> + * @sesci saved information from a coresponding call to scsi_prep_eh_cmnd
* @sesci:
> + *
> + * Undo any damage done by above scsi_prep_eh_cmnd().
> + **/
> +void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd,
> + struct scsi_eh_save_cmnd_info *sesci)
> +{
> +}
> +EXPORT_SYMBOL(scsi_eh_restore_cmnd);
Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
