On Thu, Oct 26, 2023 at 02:39:43PM +0200, Hannes Reinecke wrote: > On 10/26/23 14:24, Benjamin Block wrote: > > On Mon, Oct 23, 2023 at 11:28:31AM +0200, Hannes Reinecke wrote: > >> diff --git a/drivers/scsi/pcmcia/nsp_cs.h b/drivers/scsi/pcmcia/nsp_cs.h > >> index 01c0d571de90..0d03b361ed72 100644 > >> --- a/drivers/scsi/pcmcia/nsp_cs.h > >> +++ b/drivers/scsi/pcmcia/nsp_cs.h > >> @@ -297,8 +297,6 @@ static int nsp_show_info (struct seq_file *m, > >> static int nsp_queuecommand(struct Scsi_Host *h, struct scsi_cmnd *SCpnt); > >> > >> /* Error handler */ > >> -/*static int nsp_eh_abort (struct scsi_cmnd *SCpnt);*/ > >> -/*static int nsp_eh_device_reset(struct scsi_cmnd *SCpnt);*/ > > > > Hmm, this is a bit off-topic; is it? You don't change anything else in this > > header. Hmm, maybe because it's the old device-reset handler that still has > > `scsi_cmnd` as arg. > > > Yes. They've been commented out for ages, and will just serve to confuse > users if they remain in the code. > But I can drop this bit if you insist. Not particularly. The part about confusion because of the changed arg is true, so we might as well remove it. -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
