On 10/21/23 12:21, Greg KH wrote:
On Mon, Oct 16, 2023 at 09:26:00AM +0200, Milan Broz wrote:
This patch adds a parameter to use driver_info translation function
(which will be defined in the following patch).
Only USB storage driver will use it, as other drivers do not need
more than 32-bit quirk flags.
Then this really should be renamed to be something else.
Having a parameter be "0" means we have to go and look up the function
and see what it does and why everyone is passing 0 to it.
Make a "wrapper" function, and rename it to be something sane that does
not need the extra option, and then for the one place you do need it,
use a different function name and then both call the real function.
Does that makes sense?
Yes, fixed in v3 - and as it really simplified the patch to just few lines,
I merged in to one patch (as we touch these lines there anyway, it is
IMO more readable to have it in one patch).
Thanks!
Milan
